[Webkit-unassigned] [Bug 174443] Add BenchmarkRunner patches with WebDriver support for each testing plan

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174443

dewei_zhu at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dewei_zhu at apple.com

--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 315308
  --> https://bugs.webkit.org/attachment.cgi?id=315308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315308&action=review

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:44
> +            if self._driver == 'websocket':
> +                if 'websocket_benchmark_patch' in self._plan:
> +                    self._apply_patch(self._plan['websocket_benchmark_patch'])
> +            else:
> +                if 'webdriver_benchmark_patch' in self._plan:
> +                    self._apply_patch(self._plan['webdriver_benchmark_patch'])

It would be clearer:
patch_file_key = "{driver_name}_benchmark_patch".format(driver_name=self._driver)
if patch_file_key in self._plan:
    self._apply_patch(self._plan[patch_file_key])

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170718/04a9a980/attachment.html>