[Webkit-unassigned] [Bug 174445] Add WebDriver support in browser driver part of BenchmarkRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174445

Stephanie Lewis <slewis at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315719|review?                     |review+
              Flags|                            |

--- Comment #6 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 315719
  --> https://bugs.webkit.org/attachment.cgi?id=315719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315719&action=review

Otherwise patch looks awesome!

> Tools/ChangeLog:8
> +        * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

This changelog is long enough that you should have a paragraph under the reviewed bit describing in more detail what it does.  Also some minimal annotation on the various functions to describe their purpose can be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170717/8d6ec841/attachment-0001.html>