[Webkit-unassigned] [Bug 174469] New: Undesired fallthrough in ComputedStyleExtractor::propertyValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 13 11:22:21 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174469

            Bug ID: 174469
           Summary: Undesired fallthrough in
                    ComputedStyleExtractor::propertyValue
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

This new warning from GCC 7 has found a problem in ComputedStyleExtractor::propertyValue:

[2701/5861] Building CXX object Source.../css/CSSComputedStyleDeclaration.cpp.o
../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In member function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout)’:
../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3344:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
             }
             ^
../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3345:9: note: here
         case CSSPropertyTextIndent: {
         ^~~~

Looking at the code, the fallthrough there appears to almost surely be undesired. But I have no clue how to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170713/f76254e6/attachment-0001.html>


More information about the webkit-unassigned mailing list