[Webkit-unassigned] [Bug 174467] New: Incorrect assertion in JSC::CallLinkInfo::callTypeFor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174467

            Bug ID: 174467
           Summary: Incorrect assertion in JSC::CallLinkInfo::callTypeFor
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org
            Blocks: 174463

In CallLinkInfo::callTypeFor, the assertion ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments) should surely be ASSERT(opcodeID == op_tail_call_varargs || opcodeID == op_tail_call_forward_arguments). Currently it always passes because op_tail_call_forward_arguments is nonzero.

This was introduced in r205462. It's found by a new GCC warning:

[522/5861] Building CXX object Source/...ptCore.dir/bytecode/CallLinkInfo.cpp.o
In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0,
                 from ../../Source/WTF/wtf/FastMalloc.h:26,
                 from ../../Source/JavaScriptCore/config.h:31,
                 from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:26:
../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: In static member function ‘static JSC::CallLinkInfo::CallType JSC::CallLinkInfo::callTypeFor(JSC::OpcodeID)’:
../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:54:48: warning: enum constant in boolean context [-Wint-in-bool-context]
     ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments);
                                                ^
../../Source/WTF/wtf/Assertions.h:296:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=174463
[Bug 174463] [GTK] Fix compiler warnings when building with GCC 7
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170713/dea02dde/attachment-0001.html>