[Webkit-unassigned] [Bug 166682] Add initial implementation of WebDriver process to run the HTTP server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166682

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #5)
> Comment on attachment 315232 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315232&action=review
> 
> Wow, that's a bit of code.

Indeed.

> > Source/WebDriver/CommandResult.cpp:60
> > +    case -32700: // ParseError
> > +    case -32600: // InvalidRequest
> > +    case -32601: // MethodNotFound
> 
> Where are these numbers defined?

JSON-RPC 2.0, I copied them from BackendDispatcher::sendPendingErrors().

> > Source/WebDriver/CommandResult.cpp:125
> > +    return 200;
> 
> 500?

I think it doesn't really matter, this is mostly to silence GCC.

> > Source/WebDriver/Session.cpp:1046
> > +    case 0xE001U:
> 
> How can String::operator[] return values greater than 0xFFFF?  And what are
> these values?

Copied the values from selenium, see https://github.com/SeleniumHQ/selenium/blob/master/cpp/webdriver-interactions/keycodes.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170713/7e332e8d/attachment.html>