[Webkit-unassigned] [Bug 174445] Add WebDriver support in browser driver part of BenchmarkRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174445

Stephanie Lewis <slewis at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slewis at apple.com

--- Comment #2 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 315317
  --> https://bugs.webkit.org/attachment.cgi?id=315317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315317&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:29
> +        args.insert(2, url)

This feels clunky.  Given this code is duplicated below I think it worth having helper function just to give it a name like insert_url_into_arguments.  Also rather than changing the args array itself I'd make a new array so we don't have to worry about the constants being in a bad state.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:25
> +        args.insert(0, url)

ditto.  Your insert function should probably take a pos and return the new args array and can be used in both places.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170713/369aad6b/attachment.html>