[Webkit-unassigned] [Bug 166682] Add initial implementation of WebDriver process to run the HTTP server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166682

--- Comment #9 from Brian Burg <bburg at apple.com> ---
(In reply to Michael Catanzaro from comment #7)
> Comment on attachment 315232 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315232&action=review
> 
> > Source/WebDriver/CMakeLists.txt:29
> > +set(WebDriver_SCRIPTS
> > +    ${WEBKIT2_DIR}/UIProcess/Automation/atoms/ElementAttribute.js
> > +    ${WEBKIT2_DIR}/UIProcess/Automation/atoms/ElementDisplayed.js
> > +    ${WEBKIT2_DIR}/UIProcess/Automation/atoms/FindNodes.js
> > +    ${WEBKIT2_DIR}/UIProcess/Automation/atoms/FormElementClear.js
> > +    ${WEBKIT2_DIR}/UIProcess/Automation/atoms/FormSubmit.js
> > +)
> 
> This is unusual layering...?

WebKit2 is where most of WebDriver support in WebKit is implemented. And, for safaridriver and webkitgtkdriver to share the same atoms and work in Apple's wonky production build system, the atoms need to be copyable as framework private headers.

In any case, WebDriver should be building after WebKit2. We build safaridriver as a dependent of Safari itself due to some shared code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170712/f61e92c9/attachment-0001.html>