[Webkit-unassigned] [Bug 174421] Web Automation: evaluateJavaScriptFunction should start the callback timeout after the function is applied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 12 10:28:28 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174421

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315235|review?                     |review+
              Flags|                            |

--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 315235
  --> https://bugs.webkit.org/attachment.cgi?id=315235
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315235&action=review

r=me

For some reason, this test passes in safaridriver without the patch. I agree that this is a valid fix though.

> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.js:54
> +        let reportResult = (result) => { clearTimeout(timeoutIdentifier); resultCallback(frameID, callbackID, this._jsonStringify(result), false); resultReported = true; };

This is getting unwieldy, can you add newlines to the function?

The clearTimeout won't do anything if the function being evaluated calls the callback/completion handler synchronously. I guess that's okay.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170712/441e9a83/attachment-0001.html>


More information about the webkit-unassigned mailing list