[Webkit-unassigned] [Bug 174424] New: bmalloc: Failure to build when the compiler specifically targets ARMv8-A / defines __ARM_ARCH_8A__

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174424

            Bug ID: 174424
           Summary: bmalloc: Failure to build when the compiler
                    specifically targets ARMv8-A / defines __ARM_ARCH_8A__
           Product: WebKit
           Version: Other
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: bmalloc
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: ggaren at apple.com

The following error prevents builds from succeeding when a compiler specifically
targets ARMv8-A (instead of generic ARMv8):

  In file included from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BAssert.h:28:0,
                   from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BumpAllocator.h:29,
                   from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/Allocator.h:29,
                   from /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/Allocator.cpp:26:
  /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:84:45: warning: "BARM_ARCH_VERSION" is not defined [-Wundef]
   #define BARM_ARCH_AT_LEAST(N) (BCPU(ARM) && BARM_ARCH_VERSION >= N)
                                               ^
  /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:180:9: note: in expansion of macro ‘BARM_ARCH_AT_LEAST’
   #  elif BARM_ARCH_AT_LEAST(4)
           ^~~~~~~~~~~~~~~~~~
  /home/aperez/devel/wpe/buildroot/output/build/webkitgtk-2.16.5/Source/bmalloc/bmalloc/BPlatform.h:184:6: error: #error "Not supported ARM architecture"
   #    error "Not supported ARM architecture"
        ^~~~~

The compiler is GCC 6.4.0, and it's defining __ARM_ARCH_8A__, which is not checked
by BPlatform.h (it checks for __ARM_ARCH_8__ instead). Compiler output:

  % ./output/host/bin/arm-buildroot-linux-gnueabihf-g++ -E -dM -x c++ -std=c++1y /dev/null|grep ARM_ARCH_8                                                                                         
  #define __ARM_ARCH_8A__ 1 
  % ./output/host/bin/arm-buildroot-linux-gnueabihf-g++ -dumpversion                                      
  6.4.0

I'm submitting a patch for this soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170712/ac3d324f/attachment-0001.html>