[Webkit-unassigned] [Bug 174393] AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 11 17:46:53 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174393

--- Comment #9 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 315196
  --> https://bugs.webkit.org/attachment.cgi?id=315196
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315196&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1752
> +    auto searchRange = Range::create(m_document, startPosition, endPosition);

another Range::Create here

> Source/WebCore/accessibility/AXObjectCache.h:336
> +    RefPtr<Range> rangeMatchesTextNearRange(RefPtr<Range> originalRange, const String& matchText);

probably don't need to put argument names here

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:64
> +#import <UIKit/UIGeometry.h>

what is this one used for?

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1489
> +    AccessibilityTextMarker* startMarker = 0;

nullptr

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1490
> +    AccessibilityTextMarker* endMarker = 0;

nullptr

> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:1207
> +    

extra line

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170712/28cfa53f/attachment-0001.html>


More information about the webkit-unassigned mailing list