[Webkit-unassigned] [Bug 174390] Subclass Benchmark Runner script for future Web Driver support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174390

--- Comment #2 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 315164
  --> https://bugs.webkit.org/attachment.cgi?id=315164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315164&action=review

good job.  Just fix up webdriver and websocket and I think we'll be good.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:62
> +        pass

Probably should dump an error message if this version of the function gets called.  Something about instantiating an abstract class

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:100
> +        pass

ditto

> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:40
> +    parser.add_argument('--driver', dest='driver', default='web-socket', choices=['web-driver', 'web-socket'])

webdriver I think should be one word same for websocket

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170711/be72d06d/attachment.html>