[Webkit-unassigned] [Bug 174357] [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174357

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #315095|review?                     |review+
              Flags|                            |

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 315095
  --> https://bugs.webkit.org/attachment.cgi?id=315095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315095&action=review

> Source/WebCore/platform/glib/FileSystemGlib.cpp:430
> +    return (result != -1);

I would write these without the parens.

> Source/cmake/OptionsGTK.cmake:202
> +set(glib_components gio gio-unix gobject gthread gmodule)

I was going to say you can't use gio-unix unconditionally, but I guess you actually can. I suppose gio-unix is available on Mac. OK then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170711/9a279c2f/attachment.html>