[Webkit-unassigned] [Bug 174331] Add setup script for Web Driver part of Benchmark Runner script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174331

--- Comment #6 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 315054
  --> https://bugs.webkit.org/attachment.cgi?id=315054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315054&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:29
>  

This needs to have a proper error message.

> Tools/Scripts/webkitpy/benchmark_runner/setup.py:15
> +

Constants should be uppercase

> Tools/Scripts/webkitpy/benchmark_runner/setup.py:39
> +        if subprocess.call(['curl', '--silent', '--location', '--remote-name', 'https://bootstrap.pypa.io/get-pip.py'], shell=False):

Check with Dean but I believe we should be installing pip using easy_install.  This won't work in the lab due to the firewalls.

> Tools/Scripts/webkitpy/benchmark_runner/setup.py:52
> +        output = subprocess.check_output(['chromedriver', '--version']).strip()

Lets break the version check out into its own function.  Bonus points if firefox and chrome can use the same function.

> Tools/Scripts/webkitpy/benchmark_runner/setup.py:128
> +        print("Note: This script may not put the binaries in the correct place\nYou'll have to move them manually")

Where will it put them and where do they need to be.  Let's make these instructions detailed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170711/fa189781/attachment.html>