[Webkit-unassigned] [Bug 174239] WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174239

--- Comment #8 from Brady Eidson <beidson at apple.com> ---
(In reply to Ansh Shukla from comment #6)
> (In reply to Brady Eidson from comment #5)
> > 
> > Or more casually:
> > https://developer.mozilla.org/en-US/docs/Web/API/Window/open
> > "An optional parameter listing the features (size, position, scrollbars,
> > etc.) of the new window as a DOMString."
> 
> I saw this page, but the later statement
> 
> "the features that are not listed will be disabled or removed (except
> titlebar and close, which are by default yes)"
> 
> led me to believe that WebCore::WindowFeatures was intentionally reverting
> to defaults for unspecified values. Since it seems that our implementation
> is broken, I'll upload a patch with optional properties.

The spec has recommended default values.

But you're confusing the expectations of the window with what the API represents, which is whether or not the value was specified at all.

Some examples:

Javascript: 
window.open("about:blank", "_top", "toolbar=yes");
API WKWindowFeatures.toolbarsVisibility:
[NSNumber numberWithBool:YES]

Javascript: 
window.open("about:blank", "_top", "toolbar=no");
API WKWindowFeatures.toolbarsVisibility:
[NSNumber numberWithBool:NO]

Javascript: 
window.open("about:blank", "_top");
API WKWindowFeatures.toolbarsVisibility:
nil


Note: This doesn't actually work today as established - that's what the other bug covers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170707/6ef05410/attachment.html>