[Webkit-unassigned] [Bug 174224] WKWebSiteDataStore.removeDataOfTypes should wait until disk cache files are actually removed before invoking completion handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174224

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org
 Attachment #314773|review?                     |review+
              Flags|                            |

--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 314773
  --> https://bugs.webkit.org/attachment.cgi?id=314773
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314773&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:567
> +    keysToRemove.reserveCapacity(keys.size());

You can call reserveInitialCapacity() here.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:581
> +            RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler)] {

I think you can just pass completionHandler to RunLoop::main().dispatch() (not completely sure the types are the same).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170706/d12d33d8/attachment.html>