[Webkit-unassigned] [Bug 172585] Gracefully handle failures in websockets on wincairo
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 5 14:06:29 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=172585
Alex Christensen <achristensen at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #311211|review? |review-
Flags| |
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 311211
--> https://bugs.webkit.org/attachment.cgi?id=311211
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=311211&action=review
> Source/WebCore/ChangeLog:3
> + Handle failures in websocket on wincairo
This is a great thing. Sorry I didn't notice this patch earlier. Let's polish it up and land it.
> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:283
> + callOnMainThread([this, ret] {
> + // Check reference count to fix a crash.
This is a bad pattern I think we shouldn't expand upon. Capture protectedThis = makeRef(*this) to make sure this isn't deallocated underneath us while waiting for the lambda to be called on another thread.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170705/c57fdaea/attachment-0001.html>
More information about the webkit-unassigned
mailing list