[Webkit-unassigned] [Bug 174149] New: CSSFontStyleValue::isItalic seems a bit bogus.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174149

            Bug ID: 174149
           Summary: CSSFontStyleValue::isItalic seems a bit bogus.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ecobos at igalia.com
                CC: hyatt at apple.com, koivisto at iki.fi, mmaxfield at apple.com

bool isItalic() const
    {
        if (!obliqueValue) {
            auto valueID = fontStyleValue->valueID();
            return valueID == CSSValueItalic || CSSValueOblique;
        }
        return obliqueValue->value<float>(CSSPrimitiveValue::CSS_DEG) >= static_cast<float>(italicValue());
    }

Note how "|| CSSValueOblique" makes the first return always return true.

I'm not familiar with this code, so I'm not sure how to best test it.

Happy to fix it with indications on how to test it. I've CCd the original patch author and reviewer so you can take a look (and fix) if you want to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170705/696000ac/attachment.html>