[Webkit-unassigned] [Bug 174145] New: We resolve on extra element's style when calling getComputedStyle on a display: none subtree, I think

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174145

            Bug ID: 174145
           Summary: We resolve on extra element's style when calling
                    getComputedStyle on a display: none subtree, I think
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ecobos at igalia.com
                CC: koivisto at iki.fi

Noticed this while trying to construct a test-case for bug 172753.

In Element::resolveComputedStyle:

        elementsRequiringComputedStyle.prepend(&ancestor);
        if (auto* existingStyle = ancestor.existingComputedStyle()) {
            computedStyle = existingStyle;
            break;
        }

I think that we resolve style when not needed for that ancestor we find an existing computed style for...

Also, I think, that we resolve the first element inheriting from itself, which seems wrong (though I don't think it's observable, fwiw)... Will post a patch here to run through CI, and will update for review when needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170705/c9e35c7f/attachment-0001.html>