[Webkit-unassigned] [Bug 174056] WIP - RunBenchmark WebDriver testing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174056

--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 314327
  --> https://bugs.webkit.org/attachment.cgi?id=314327
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314327&action=review

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/benchmark_runner.py:74
> +            url = 'file://' + web_root + '/' + self._plan_name + '/' + test_file

This would look a lot better using a template/format string.

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/browser_driver/osx_safari_driver.py:30
> +        self._launch_driver(build_dir=browser_build_path, app_name="Safari.app", url=url, args=["-HomePage", "about:blank", "-WarnAboutFraudulentWebsites", "0", "-ExtensionsEnabled", "0", "-ShowStatusBar", "0", "-NewWindowBehavior", "1", "-NewTabBehavior", "1"], driver=driver)

If these are needed to avoid hangs while running WebDriver tests, you should file a bug against safaridriver. Hangs should never happen during a WebDriver test.

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/browser_driver/osx_safari_driver.py:39
> +    def _maximize_window(cls):

You can do this via WebDriver API. Why is this needed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170703/0056965e/attachment.html>