[Webkit-unassigned] [Bug 165075] REGRESSION(r200346): WTFLogVerbose is passing arguments to WTFLog incorrectly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 12:06:16 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=165075

--- Comment #1 from Keith Rollin <krollin at apple.com> ---
WTFLogVerbose is referenced in only one place:


$ rg -w WTFLogVerbose
WTF/wtf/Assertions.cpp
495:void WTFLogVerbose(const char* file, int line, const char* function, WTFLogChannel* channel, const char* format, ...)

WTF/wtf/Assertions.h
175:WTF_EXPORT_PRIVATE void WTFLogVerbose(const char* file, int line, const char* function, WTFLogChannel*, const char* format, ...) WTF_ATTRIBUTE_PRINTF(5, 6);
407:#define LOG_VERBOSE(channel, ...) WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, &LOG_CHANNEL(channel), __VA_ARGS__)

WebCore/platform/NotImplemented.h
48:            WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, WebCore::notImplementedLoggingChannel(), "UNIMPLEMENTED: "); \


However, this "one place" is the definition of the notImplemented macro, which is used in about 763 places.

As indicated by the title, this issue is related to Bug 157274.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170130/32df3d20/attachment.html>


More information about the webkit-unassigned mailing list