[Webkit-unassigned] [Bug 167003] REGRESSION(r202615?): [GStreamer] ASSERTION FAILED: isMainThread() in WebCore::BuiltinResourceHandleConstructorMap& WebCore::builtinResourceHandleConstructorMap()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167003

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300089|review?                     |review+
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 300089
  --> https://bugs.webkit.org/attachment.cgi?id=300089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300089&action=review

> Source/WebCore/ChangeLog:13
> +        (ResourceHandleStreamingClient::ResourceHandleStreamingClient): Create a SoupNetworkSession and apss it to ResourceHandle::create().

apss -> pass

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1086
> +#else
>              m_resource = ResourceHandle::create(nullptr /*context*/, request, this, true, false);
> +#endif

But this is always going to crash in the non-soup case.

Since there are zero non-soup ports using GStreamer (even Sony wants to avoid GStreamer), you should make it mandatory instead of leaving this broken code here for new ports to stumble upon. If you don't want to do that, then at the very least use RELEASE_ASSERT_NOT_REACHED() and add a FIXME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170130/67b89bb2/attachment.html>