[Webkit-unassigned] [Bug 162124] op_get_by_id_with_this should use inline caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162124

--- Comment #69 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to comment #68)
> (In reply to comment #67)
> > Comment on attachment 300066 [details]
> > Patch rebased
> > 
> > I cannot find the part preventing us from using DOMJIT for
> > op_get_by_id_with_this. Could you point this part?
> 
> I'm not sure if I understood. The previous Patch was configuring a "this"
> operand of a DOMJIT IC however I removed that code. Should we also cancel
> emmit IC in that case?
> 
> Here is the code in the old Patch:
> 
> https://bugs.webkit.org/attachment.cgi?id=297746&action=diff#a/Source/
> JavaScriptCore/bytecode/PolymorphicAccess.cpp_sec2

Yes, DOMJIT IC should not be emitted for op_get_by_id_with_this case since it is imcompatible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170129/587bdf65/attachment.html>