[Webkit-unassigned] [Bug 167415] Avoid evicting link preload resources when parsing is done.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167415

--- Comment #20 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 299837
  --> https://bugs.webkit.org/attachment.cgi?id=299837
Patch

I guess an alternative would be to restrict m_preloads to speculative preloads only.
Can we do that?
Also, if we do not fully clean m_preloads at onload time, won't we keep references to these resources?
If so, we might not be able to reclaim memory on these, even if MemoryCache is asked to do so.

View in context: https://bugs.webkit.org/attachment.cgi?id=299837&action=review

> Source/WebCore/ChangeLog:14
> +        being cleared), said issue is also fixed by clearing previousely preloaded resources if an invalid link preload is later detected.

What happens if a speculative preload is scheduled first and a link preload on the same resource happens after.
Shouldn't the speculative preload be marked as link preload?

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:870
> +        resource->setLinkPreload();

This should be done in CachedResource constructor.
Maybe we should in the future make CachedResource have a CachedResourceRequest member.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170127/3b02764c/attachment.html>