[Webkit-unassigned] [Bug 166955] AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166955

--- Comment #23 from Nan Wang <n_wang at apple.com> ---
(In reply to comment #22)
> Comment on attachment 299871 [details]
> patch with test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299871&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1863
> > +    // Sometimes we did not advance enough to create a text range, e.g. when there's a soft line break.
> 
> How does soft line break prevent Position from moving forward/backward?
> This definitely needs a test case.

It doesn't prevent position from moving forward/backward. The problem is that the offset we passed in comes from NSRange from a string and VisiblePosition sometimes need to advance more to get the same string.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170127/6a410a95/attachment.html>