[Webkit-unassigned] [Bug 167460] New: Why doesn't mandelbrot.js FTL?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167460

            Bug ID: 167460
           Summary: Why doesn't mandelbrot.js FTL?
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jfbastien at apple.com
                CC: fpizlo at apple.com, ggaren at apple.com,
                    jfbastien at apple.com, keith_miller at apple.com,
                    mark.lam at apple.com, msaboff at apple.com,
                    sbarati at apple.com
        Depends on: 167149

I added a mandelbrot test in #167149 because I wanted something with nested loops and not just int32.

This happens:

$ ./current-release/bin/jsc ./JSTests/microbenchmarks/mandelbrot.js --useConcurrentJIT=0 -p a && ./Tools/Scripts/display-profiler-output a
    CodeBlock     #Instr          Source Counts                 Machine Counts        #Compil  Inlines  #Exits   Last Opts                                                   Source                                                
                               Base/DFG/FTL/FTLOSR           Base/DFG/FTL/FTLOSR              Src/Total         Get/Put/Call
mandelbrot#DoqaAb  579          50989/4078434/0/0             50989/4078434/0/0          4       0/0      15       4/0/4     function mandelbrot(x, y, w, h, scene_i, scene_z, X, Y, iterations) { const max_z = 2.0; for (let i = 
  shade#Eqog0q     118             67/6301/0/0                   67/1911/0/0             2       2/2       0       1/0/1     function i => shades[Math.round((i * (shades.length - 1)) / max_s)]
 <global>#DMGh43   779            2543/3507/0/0                 2543/3507/0/0            2       0/0       1       3/0/3     const max_s = 255; const hysterisis = 3; function mandelbrot(x, y, w, h, scene_i, scene_z, X, Y, itera
printable#EmK4D0   135            1524/4390/0/0                 1524/4390/0/0            2       1/1       0       1/0/2     function printable(scene_i, scene_z, X, Y) { let s = ""; for (let i = 0; i < X; ++i) { for (let j = 0;
    of#A2awz5      114               0/0/0/0                       0/0/0/0               0       0/0       0        N/A      function () { "use strict"; var length = arguments.length; var array = @isConstructor(this) ? new this
   fill#AXPfsF     231               0/0/0/0                       0/0/0/0               0       0/0       0        N/A      function (value ) { "use strict"; if (this == null) @throwTypeError("Array.prototype.fill requires tha
 toLength#ESso8n    59               0/0/0/0                       0/0/0/0               0       0/0       0        N/A      function (target) { "use strict"; var length = @toInteger(target); return length > 0 ? (length < @MAX_
toInteger#BxMpe8    74               0/0/0/0                       0/0/0/0               0       0/0       0        N/A      function (target) { "use strict"; var numberValue = @Number(target); if (numberValue !== numberValue) 
> l mandelbrot
Compilation mandelbrot#DoqaAb-1-Baseline:
    Total count: 3155511  Max count: 50989
Compilation mandelbrot#DoqaAb-2-DFG:
    Total count: 530545  Max count: 5413
    EXIT: at bc#228 due to InadequateCoverage, 5 times
    Jettisoned due to BaselineLoopReoptimizationTrigger
Compilation mandelbrot#DoqaAb-3-DFG:
    Total count: 1146246  Max count: 22805
    EXIT: at bc#311 due to Overflow, 10 times
    Jettisoned due to BaselineLoopReoptimizationTrigger
Compilation mandelbrot#DoqaAb-4-DFG:
    Total count: 118896069  Max count: 4050216



That's not cool. Mandelbrot only has Number and some int32 coercion. Exit due to overflow isn't a good reason to not FTL here.

I'll investigate this at some point in time. It's not a rush, but good to fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170126/4d39c637/attachment-0001.html>