[Webkit-unassigned] [Bug 167328] strict mode eval doesn't initialize functions with the proper scope

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167328

--- Comment #3 from Saam Barati <sbarati at apple.com> ---
I think we should simplify how we do variables in strict mode eval.

Currently, we rely on Interpreter::execute(Eval) to create a StrictEvalActivation that contains the "function" and "var" variables in it. However, I think this is probably unnecessary. I think we can do all of this in bytecode and just create a normal JSLexicalEnvironment for the "var" variables and "function" variables inside the bytecode generator (as long as we're in strict mode). If we're in sloppy mode, we should continue to do what we do now.

Anybody have thoughts on this? Am I missing something that would make this not Just Work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170125/a710180f/attachment.html>