[Webkit-unassigned] [Bug 166955] AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 00:43:38 PST 2017


--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 299684
  --> https://bugs.webkit.org/attachment.cgi?id=299684

View in context: https://bugs.webkit.org/attachment.cgi?id=299684&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1870
> +    while (!previous.isNull() || !next.isNull()) {
> +        previous = !previous.isNull() ? previous.previous() : previous;
> +        next = !next.isNull() ? next.next() : next;

This is quite possibly the most inefficient way of expanding positions all the way to the beginning or the end of a document.
Why can't we just use findPlainText? Please explain in the change or in the comment.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170125/bcd0d702/attachment.html>

More information about the webkit-unassigned mailing list