[Webkit-unassigned] [Bug 167370] [GTK] Add API to create ephemeral web views and deprecate the private browsing setting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167370

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299599|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 299599
  --> https://bugs.webkit.org/attachment.cgi?id=299599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299599&action=review

Looking forward to the Epiphany implementation. ;)

Nice tests.

> Source/WebKit2/ChangeLog:23
> +        (webkitWebViewConstructed): Check if the WebView is or should be ephemeral and create a non persistent website
> +        data manager if it's an ephemeral web view in a non ephemeral web context.

What is the advantage to allowing users to create ephemeral web views in non-ephemeral web contexts? Is this really well-supported and unlikely to cause problems?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:506
> + * Get whether a #WebKitWebContext is ephemeral.

It would probably be advantageous to expose this implementation detail, so the user has a better clue what is going on:

"Get whether a #WebKitWebContext uses an ephemeral #WebKitWebsiteDataManager"

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:508
> + * Returns: %TRUE if @context is ephemeral or %FALSE otherwise.

You forgot the Since tag here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1002
> +     * created with an ephemeral #WebKitWebContext will be ephemeral automatically,

Another comma splice. Last time I told you to use a semicolon. This one would work better split it into two sentences.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:322
> +     * handles all websites data as non persistent, and nothing will be written to the client

non-persistent

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:426
>   * Returns: the base directory for Website data, or %NULL if

Preexisting bug: it does not have (allow-none) so bindings are broken. You won't be able to null-check it from vala, for example.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:447
>   * Returns: the base directory for Website cache, or %NULL if

(allow-none)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:468
> + * Returns: the directory where local storage data is stored or %NULL if @manager is ephemeral.

(allow-none)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:491
> + * Returns: the directory where HTTP disk cache is stored or %NULL if @manager is ephemeral.

(allow-none)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:516
> + * Returns: the directory where offline web application cache is stored or %NULL if @manager is ephemeral.

(allow-none)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:539
> + * Returns: the directory where IndexedDB databases are stored or %NULL if @manager is ephemeral.

(allow-none)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:562
> + * Returns: the directory where WebSQL databases are stored or %NULL if @manager is ephemeral.

(allow-none)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170124/7270183c/attachment-0001.html>