[Webkit-unassigned] [Bug 167355] TAKE 2: Pass down website autoplay policies to media elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 24 10:58:42 PST 2017


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
 Attachment #299566|review?                     |review-
              Flags|                            |

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 299566
  --> https://bugs.webkit.org/attachment.cgi?id=299566

View in context: https://bugs.webkit.org/attachment.cgi?id=299566&action=review

> Source/WebCore/loader/DocumentLoader.h:471
> +    std::optional<bool> m_audioPlaybackRequiresUserGesture;
> +    std::optional<bool> m_videoPlaybackRequiresUserGesture;

I think this should be a 3-state enum, probably with a different name like m_audioPlaybackPolicy.
enum class AutoplayPolicy {
    Default, <-- This name might need to be more descriptive indicating that the policy hasn't been set by the WebsitePolicies so default to the Settings value.  Maybe just a comment explaining this.
These two could probably even be made into one enum

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:820

Let's get rid of this now that it doesn't do anything for other platforms.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:823
> +        documentLoader->setAudioPlaybackRequiresUserGesture(std::optional<bool>());


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170124/371787c4/attachment.html>

More information about the webkit-unassigned mailing list