[Webkit-unassigned] [Bug 146589] [GTK] Add API to WebKitWebsiteDataManager to handle website data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146589

--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #23)
> Comment on attachment 299429 [details]
> New patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299429&action=review
> 
> > Source/WebKit2/ChangeLog:33
> > +        (webkit_website_data_manager_remove): Remove the website data of the given types for the given WebKitWebsiteData list.
> > +        (webkit_website_data_manager_remove_finish):
> > +        (webkit_website_data_manager_clear): Clear all website data of the given types modified since the given time span.
> > +        (webkit_website_data_manager_clear_finish):
> 
> I realized the distinction between _remove and _clear is too confusing. How
> about renaming _clear to _clear_all?

That's why it's documented :-) I find clear_all redundant and even more confusing, all what? all data types? of course that's why you pass the types to clear, all websites data? of course since you are not providing any. Doesn't clear implies all in English?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170124/651d7dd1/attachment.html>