[Webkit-unassigned] [Bug 167324] Maintain ordering when doing speculative loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167324

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299539|review?                     |review+
              Flags|                            |

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 299539
  --> https://bugs.webkit.org/attachment.cgi?id=299539
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299539&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:109
> +    Vector<SubresourceInfo> result;

I think we should reserveInitialCapacity() and uncheckedAppend() since we know there will be at most subresourceLoads.size() items and the common case will be subresourceLoads.size() items.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:49
> +        , m_requestHeaders(request.httpHeaderFields())

It is a bit unfortunate that we are now copying those HashMaps for transient resources too now. I hope this does not show on PLT.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170123/f55b6a16/attachment-0001.html>