[Webkit-unassigned] [Bug 166794] AX: Speak Selection does not work in an iframe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 12:53:10 PST 2017


--- Comment #10 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 299368
  --> https://bugs.webkit.org/attachment.cgi?id=299368
patch with test

View in context: https://bugs.webkit.org/attachment.cgi?id=299368&action=review

> Source/WebKit2/ChangeLog:8
> +

will this also handle the case of just text nodes highlighted (I ask because I don't know if focus moves to a frame if you just highlight text in that frame)

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2333
> +{

can you put a comment here about who uses this

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:116
> +    [webView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:^(void) {

(void) probably not necessary to include

^{ probably will work

> LayoutTests/accessibility/ios-simulator/speak-selection-content.html:17
> +<input type="text" id="myText" value="Text outside iframe">

let's also test selecting text that's not inside a input type

> LayoutTests/platform/ios-simulator-wk1/TestExpectations:108
> +# Not support on WK1

Not supported

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170120/e0554cef/attachment-0001.html>

More information about the webkit-unassigned mailing list