[Webkit-unassigned] [Bug 165237] [GTK] The inspector is broken when AC support is disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 08:42:10 PST 2017


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |achristensen at apple.com,
                   |                            |cgarcia at igalia.com,
                   |                            |magomez at igalia.com,
                   |                            |simon.fraser at apple.com,
                   |                            |thorton at apple.com,
                   |                            |yoon at igalia.com,
                   |                            |zan at falconsigh.net

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
This is not specific to GTK+, but I guess it doesn't happen in other ports based on coordinated graphics because they don't allow to disable accelerated compositing. The problem is that PageOverlay depends on accelerated compositing and assumes it's always available. We get also crashes if accelerated compositing is not forced when the roo layer is detached, because the page overlay controller keep its graphics layer alive. In coordinated graphics the layers have a coordinator associated, when the coordinator is destroyed, it expects all the layers to be also destroyed, but that's not true for the page olverlays. So, I think we should do two things here:

 1. Do not use page overlays when accelerated compositing is disabled. The same way RenderLayercompositor doesn't create any GraphicsLayer when AC is disabled. Features depending on page overlays will not work of course, but that's better than crashing. I think the GTK+ port only uses page overlays for the inspector highlights, so not a big deal.

 2. When RenderLayerCompositor detaches the root layer, and we leave accelerated compositor mode, the page overlays should be destroyed to ensure we don't leave any GraphicsLayer pointing to a deleted coordindator.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170120/e0e0497a/attachment.html>

More information about the webkit-unassigned mailing list