[Webkit-unassigned] [Bug 167136] Persist derived data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167136

--- Comment #6 from Andreas Kling <akling at apple.com> ---
Comment on attachment 299060
  --> https://bugs.webkit.org/attachment.cgi?id=299060
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299060&action=review

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:575
> +            RefPtr<NetworkResourceLoader> loader(this);

You could capture this with makeRef(*this) instead.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:354
> -    m_storage->retrieve(storageKey, priority, [this, request, completionHandler = WTFMove(completionHandler), startTime, storageKey, frameID](std::unique_ptr<Storage::Record> record) {
> +    m_storage->retrieve(storageKey, priority, [this, request, completionHandler = WTFMove(completionHandler), startTime, storageKey, frameID](auto record) {

This seems a little unrelated, but sure.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:634
> +{

This function should return if the cache is not enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170118/9f6cbb34/attachment.html>