[Webkit-unassigned] [Bug 167022] Ignore Connection Assertion if we are not using connection to send messages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 09:23:43 PST 2017


--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
(In reply to comment #6)
> A pointer is not a good identifier, because the same memory location can be
> reused.
> What is the higher level problem being solved by this check?
We need a way to get the WebProcessProxy from WebPasteboardProxy::setPasteboardPathnamesForType so we can use it to check the URL coming from the WebProcess.  I suggested just casting the Connection's client to a WebProcessProxy, but Anders said that would become unsafe and I agree.  We have a Connection, but WebProcessProxy::didReceiveMessage doesn't forward *this to ChildProcessProxy::dispatchMessage because MessageReceiver::didReceiveMessage doesn't always have something forwarding the message to it.  Another solution might be to make a ForwardedMessageReceiver<typename Forwarder> that has a didReceiveMessage that has a reference to the original receiver of the message, but I'm not sure it would be worth it just for this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170117/37991c74/attachment.html>

More information about the webkit-unassigned mailing list