[Webkit-unassigned] [Bug 167066] New: JSCell::classInfo() shouldn't have a bunch of mitigations for being called during destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167066

            Bug ID: 167066
           Summary: JSCell::classInfo() shouldn't have a bunch of
                    mitigations for being called during destruction
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

Every time you use JSCell::classInfo(), you pay a compile time, code size, and running time cost for mitigations that are there to make that method safe to call from a destructor.

The only reason why we call that method in destructors is:

- Invalid use of jsCast<>.  We used to have the discipline to only use static_cast<> in destructors.
- Some isolated uses of the classInfo in specific subclasses.  Those can do the mitigations themselves.

We should also assert in classInfo() that we aren't destructing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170115/52890551/attachment-0001.html>