[Webkit-unassigned] [Bug 166029] [GTK] SoupCookieJar is never released (resulting in sqlite temp files lying around)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166029

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.gnome.org/
                   |                            |show_bug.cgi?id=774011

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
I just found:

https://bugzilla.gnome.org/show_bug.cgi?id=774011

which I reported not so long ago, but forgot about.

There I discovered that we have the following code in WebKit in SoupCookieJar.cpp:

void deleteAllCookies(const NetworkStorageSession& session)
{
    SoupCookieJar* cookieJar = cookieJarForSession(session);
    GUniquePtr<GSList> cookies(soup_cookie_jar_all_cookies(cookieJar));
    for (GSList* item = cookies.get(); item; item = g_slist_next(item)) {
        SoupCookie* cookie = static_cast<SoupCookie*>(item->data);
        soup_cookie_jar_delete_cookie(cookieJar, cookie);
        soup_cookie_free(cookie);
    }
}

Note that we need to free the cookie jar there too, else the delete all cookies feature will not remove the .sqlite-wal and .sqlite-shm files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170115/f7d2b468/attachment-0001.html>