[Webkit-unassigned] [Bug 124268] Web Inspector: Build script can't handle line or block comments in Inspector.json.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 17:25:03 PST 2017


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |bburg at apple.com

--- Comment #7 from Brian Burg <bburg at apple.com> ---
I don't think it's worth making our JSON not proper JSON just to make it easy to comment out sections of it. You can easily just delete and selectively revert with git/svn.

If you really just want to selectively disable certain commands/events/domains locally without deleting them, it would be trivial to add a fake Platform to the generator then set the 'platform' property to it. This would cause it to not match the generator's platform (mac or ios) and boilerplate for the command wouldn't be generated.

If that is sufficient, I can retitle this and fix it quite quickly. If this is really about comment syntax, I think we should close this bug as NTBF.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170114/ab549ed7/attachment.html>

More information about the webkit-unassigned mailing list