[Webkit-unassigned] [Bug 166955] AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166955

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298733|                            |review-
              Flags|                            |

--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 298733
  --> https://bugs.webkit.org/attachment.cgi?id=298733
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298733&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:101
> +    RectForPointWithOffset(WebCore::IntPoint point, int32_t offset) -> (WebCore::FloatRect rect);
> +    SelectionRectsForPositions(WebCore::IntPoint from, WebCore::IntPoint to) -> (Vector<WebCore::SelectionRect> selectionRects, uint64_t length);
> +    SelectionRectsForGranularityAtPosition(WebCore::IntPoint point, uint32_t granularity) -> (Vector<WebCore::SelectionRect> selectionRects, WebCore::FloatRect startRect, WebCore::FloatRect endRect, uint64_t length);

Please do not add any additional synchronous messages (an please don't call any existing ones).  Please re-work this to not require synchronous messaging to the WebProcess.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170113/ae2f76d0/attachment.html>