[Webkit-unassigned] [Bug 166967] [SOUP] Simplify cookie storage handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 10:20:41 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=166967

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #9)
> > It's true that for every
> > session, if the cookie storage is asked before the soup session is created,
> > when the soup session is created we have two references of the cookie jar,
> > we could probably clear the NetworkStorageSession one in that case. That can
> > only happen for the default session, all others are created with a
> > SoupNetworkSession.
> 
> OK, I think you should indeed clear the NetworkStorageSession jar and have
> it return the SoupNetworkSession jar instead. Even if it's the same thing,
> that would make the code clearer and more robust.

Um, I see the current code already returns the SoupNetworkSession's pointer to the jar. I think it should also clear the NetworkStorageSession's pointer to the jar, for clarity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170113/a077b766/attachment-0001.html>


More information about the webkit-unassigned mailing list