[Webkit-unassigned] [Bug 166981] New: DumpRenderTree's credentials should support Latin-1 encoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166981

            Bug ID: 166981
           Summary: DumpRenderTree's credentials should support Latin-1
                    encoding
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wilander at apple.com
                CC: lforschler at apple.com

DumpRenderTree's setAuthenticationUsernameCallback() and setAuthenticationPasswordCallback() always convert incoming strings to UTF-8 through JSStringGetUTF8CString(). The credentials are then stored in standard strings (std::string). This cripples non-ASCII characters in Basic Authentication to the point where they are not sent in the challenge response, creating an infinite HTTP 401 loop. After the first failed attempt, challenge.previousFailureCount() in ResourceHandle::tryHandlePasswordBasedAuthentication() returns an unsigned larger than zero and ResourceHandle::tryHandlePasswordBasedAuthentication() will no longer look for credentials in the credential storage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170112/6da77ae9/attachment.html>