[Webkit-unassigned] [Bug 166825] Move cache coders to WTF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166825

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 298319
  --> https://bugs.webkit.org/attachment.cgi?id=298319
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298319&action=review

> Source/WTF/wtf/persistence/Coders.cpp:35
> +#include "NetworkCacheCoders.h"
> +
> +#if ENABLE(NETWORK_CACHE)
> +
> +#include <wtf/text/CString.h>
> +#include <wtf/text/WTFString.h>
> +
> +namespace WebKit {
> +namespace NetworkCache {

Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace NetworkCache?

> Source/WTF/wtf/persistence/Coders.cpp:160
> +// Store common HTTP headers as strings instead of using their value in the HTTPHeaderName enumeration
> +// so that the headers stored in the cache stays valid even after HTTPHeaderName.in gets updated.
> +void Coder<WebCore::HTTPHeaderMap>::encode(Encoder& encoder, const WebCore::HTTPHeaderMap& headers)

Er, surely WTF cannot depend on WebCore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170109/d841929b/attachment.html>