[Webkit-unassigned] [Bug 166814] New: REGRESSION(r178955): Touching Settings.in doesn't cause JSInternalSettingsGenerated.cpp to be updated on first build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166814

            Bug ID: 166814
           Summary: REGRESSION(r178955): Touching Settings.in doesn't
                    cause JSInternalSettingsGenerated.cpp to be updated on
                    first build
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Bindings
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mmaxfield at apple.com
                CC: cdumez at apple.com

To reproduce on an OpenSource build:

1. Perform a full, clean build
2. Add or remove an item from Settings.in
3. In a terminal:
$ cd ~/Build/Products/Debug/DerivedSources/WebCore
$ export WebCore="WebCore"
$ export JavaScriptCore_SCRIPTS_DIR="JavaScriptCorePrivateHeaders"
$ export CC="`xcrun -find clang`"
$ export GPERF="`xcrun -find gperf`"
$ export WEBKITADDITIONS_HEADER_SEARCH_PATHS="${HOME}/Build/Products/Debug/usr/local/include/WebKitAdditions /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/local/include/WebKitAdditions"
$ export MAKEFILE_INCLUDE_FLAGS=$(echo "${WEBKITADDITIONS_HEADER_SEARCH_PATHS}" | perl -e 'print "-I" . join(" -I", split(" ", <>));')
$ make -n --no-builtin-rules ${MAKEFILE_INCLUDE_FLAGS} -f "WebCore/DerivedSources.make" SDKROOT="${SDKROOT}"

The "-n" will cause make to only print the commands it would have run. Notice that there is no generate-bindings.pl invocation in the result for InternalSettingsGenerated.idl

However, if you run the make command again (with the -n flag), there is a generate-bindings.pl invocation in the result for InternalSettingsGenerated.idl

If you run these same steps again, but you revert the last part of https://trac.webkit.org/changeset/178955/trunk/Source/WebCore/DerivedSources.make where make_settings.pl is linked to an .INTERMEDIATE rule, both make invocations list a generate-bindings.pl invocation for InternalSettingsGenerated.idl

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170108/817b84e6/attachment-0001.html>