[Webkit-unassigned] [Bug 166790] Add a test to ensure that preventDefault on touchmove prevents scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166790

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298240|review?                     |review+
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 298240
  --> https://bugs.webkit.org/attachment.cgi?id=298240
Test

View in context: https://bugs.webkit.org/attachment.cgi?id=298240&action=review

> LayoutTests/fast/events/touch/ios/iphone7/prevent-default-touchmove-prevents-scrolling.html:17
> +#scroller {
> +    border: 2px solid black;
> +    height: 400px;
> +    overflow: scroll;
> +    position:absolute;
> +}
> +        
> +#big {
> +    width:50px;
> +    height:2000px;
> +    background-color:purple;
> +    border: 15px solid green;
> +}

Would be nice to be consistent about spaces after colons.

> LayoutTests/fast/events/touch/ios/iphone7/prevent-default-touchmove-prevents-scrolling.html:69
> +               {
> +               interpolate : "linear",
> +               timestep: 0.025,
> +               startEvent : {
> +               inputType : "hand",
> +               timeOffset : 0,
> +               touches : [
> +                          {
> +                          inputType : "finger",
> +                          phase : "began",
> +                          id : 1,
> +                          x : ${startX},
> +                          y : ${startY},
> +                          pressure : 0
> +                          }
> +                          ]
> +               },
> +               endEvent : {
> +               inputType : "hand",
> +               timeOffset : 3.0,
> +               touches : [
> +                          {
> +                          inputType : "finger",
> +                          phase : "stationary",
> +                          id : 1,
> +                          x : ${endX},
> +                          y : ${endY},
> +                          pressure : 500
> +                          }
> +                          ]
> +               }
> +               }
> +               ]
> +     };

The indentation is funky.

> LayoutTests/fast/events/touch/ios/iphone7/prevent-default-touchmove-prevents-scrolling.html:73
> +                                  uiController.uiScriptComplete();
> +                                  });

Here too.

> LayoutTests/fast/events/touch/ios/iphone7/prevent-default-touchmove-prevents-scrolling.html:91
> +                            shouldBe("document.getElementById('scroller').scrollTop", "0");
> +                            finishJSTest();
> +                               });

Here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170107/f5ceb908/attachment-0001.html>