[Webkit-unassigned] [Bug 166058] [Cairo] Conditional jump or move depends on uninitialised value(s)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 4 23:29:02 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=166058

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 297518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297518&action=review
> 
> > Source/WebCore/platform/graphics/cairo/FontCairo.cpp:246
> >      cairo_glyph_t cairoGlyph;
> >      cairoGlyph.index = m_glyphBuffer.glyphAt(m_index);
> > +    cairoGlyph.x = cairoGlyph.y = 0;
> 
> These could have been written like this:
> 
> cairo_glyph_t cairoGlyph = { m_glyphBuffer.glyphAt(m_index), 0, 0 };

Indeed! Done in r210321, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170105/2634458d/attachment.html>


More information about the webkit-unassigned mailing list