[Webkit-unassigned] [Bug 166670] AX: Focus should jump into modal dialogs when one appears

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 3 17:21:18 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=166670

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 297971
  --> https://bugs.webkit.org/attachment.cgi?id=297971
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297971&action=review

> Source/WebCore/ChangeLog:9
> +        author didn't handle the focus movements.

"focus movement."

> LayoutTests/accessibility/mac/aria-modal-auto-focus.html:47
> +        newBtn  = accessibilityController.accessibleElementById("new");

extra space

> LayoutTests/accessibility/mac/aria-modal-auto-focus.html:64
> +                }, 100);

do we have to wait .1s here or can this be faster?

> LayoutTests/accessibility/mac/aria-modal-auto-focus.html:80
> +    if (sh == "show") {

bad indentation

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170104/5b3e3ce0/attachment-0001.html>


More information about the webkit-unassigned mailing list