[Webkit-unassigned] [Bug 166643] Ensure depth and stencil renderbuffers are created on GLESv2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 18:31:45 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=166643

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297917|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 297917
  --> https://bugs.webkit.org/attachment.cgi?id=297917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297917&action=review

> w/Source/WebCore/ChangeLog:3
> +        Ensure depth and stencil renderbuffers are created on GLESv2

Bug should have [Cairo] in the subject since it’s a Cairo-specific patch and bug fix.

> w/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:91
> +    , m_depthBuffer(0)
> +    , m_stencilBuffer(0)

Should initialize these in the class definition rather than adding more conditionals to the .cpp file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170103/75455cdd/attachment-0001.html>


More information about the webkit-unassigned mailing list