[Webkit-unassigned] [Bug 163892] [GTK] Add function webkit_dom_element_get_bounding_client_rect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 23:45:20 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=163892

--- Comment #21 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #20)
> (In reply to comment #19)
> > Look at the examples I mentioned above. You need to add two files
> > TestDOMFoo.cpp and DOMFooTest.cpp. The former is the test file that runs in
> > the UI process, it adds the tests cases that normally just load some html
> > and then tun the web process test simply calling
> > WebViewTest::runWebProcessTest(). The latter is the test itself that runs in
> > the web process. You have to add a class derived from WebProcessTest with a
> > method for very tests case and override runTest that dispatches the test
> > cases. To register the tests we use a lib constructor that uses the macro
> > REGISTER_TEST.
> 
> Thanks for the guidelines; seems pretty straightforward. Is there any way to
> run only the WebKitDOM tests while I develop?

Yes, run-gtk-tests allows to run individual tests, you just need to pass the path to the test, for example:

Tools/Scripts/run-gtk-tests --verbose WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDOMNode

> Separately, is it alright to keep tests for both ClientRect and
> ClientRectList in the same pair of files? Or should I separate them?

It's ok to use the same file with two different test cases for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/3ff795ee/attachment-0001.html>


More information about the webkit-unassigned mailing list