[Webkit-unassigned] [Bug 163892] [GTK] Add function webkit_dom_element_get_bounding_client_rect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163892

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #19 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #18)
> My opinion is that DOM API doesn't need tests, since none of the rest of the
> API has tests. But Carlos's opinion wins.

It's not a matter of opinion, it's that this is not true. We have DOM API tests, I added the concept of "web process tests" precisely to test DOM API. We currently have:

TestDOMNode.cpp
TestDOMNodeFilter.cpp
TestDOMXPathNSResolver.cpp

I agree that we don't need very complex tests, because the actual functionality is in WebCore and already tested by layout tests using the JS API.

> Look in
> Tools/TestWebKitAPI/Tests/WebKitGTK+ for e.g. the web extension test as an
> example.

Look at the examples I mentioned above. You need to add two files TestDOMFoo.cpp and DOMFooTest.cpp. The former is the test file that runs in the UI process, it adds the tests cases that normally just load some html and then tun the web process test simply calling WebViewTest::runWebProcessTest(). The latter is the test itself that runs in the web process. You have to add a class derived from WebProcessTest with a method for very tests case and override runTest that dispatches the test cases. To register the tests we use a lib constructor that uses the macro REGISTER_TEST.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/195264cd/attachment-0001.html>