[Webkit-unassigned] [Bug 168699] [GTK] Hangs when showing Google search results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 22:33:21 PST 2017


--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #17)
> (In reply to comment #16)
> > Right, now that EFL is gone, that's exactly my plan. We could also make it
> > ifdef free by converting our socket monitor into a platform-specific class
> > with platform implementations. However, now that there's no other unix ports
> > using this code, it's not easy for me to do that refactoring without knowing
> > the other implementations.
> Let's do this. Solution is to rename it to ConnectionGLib.cpp and just
> remove ConnectionUnix.cpp. If some future port wants to use it, they can
> bring it back at that time.

No, I haven't proposed this, a possible ConnectionGLib would be quite different (and simpler) using the GSocket API por everything. ConnectionUnix is common code except for the socket monitor, so let's just change the ifdefs to USE(GLIB). What I proposed was to make the socket monitor a common interface with platform implementations not the whole file. When we added this implementation, we (GTK, EFL and Qt ports) decided not to use platform APIs for this, to share the implementation.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/c8488a49/attachment.html>

More information about the webkit-unassigned mailing list